-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: Terminal Manager #12726
base: master
Are you sure you want to change the base?
Draft: Terminal Manager #12726
Conversation
@kenneth-marut-work the title says "draft", but it's a regular non-draft PR. What's the truth? |
Ah, I see. thanks @colin-grant-work |
This is great! What would need to be done to bring this feature up to scratch? |
I think there are quite a lot of nice-to-have features missing (menu items/actions that you can perform on individual terminals, shell & task detection etc.). But I think most importantly the
|
@conordavenport Are you interested in picking up this work? |
@conordavenport Could you give an update on this please? Did you grap the code so that we can close this PR? Do you plan to do a contribution here? |
What it does
Relevant to #12673
This is PR adds the package
terminal-manager
, which was built for our downstream IDE. It is heavily inspired by VSCode's split-panel terminal view + tree, but not an exact copy. The terminal manager is separate widget that supplements the existing terminals inside Theia but is not meant as a replacement (at the moment). The terminal-manager's purpose is to serve as a place to maintain and organize terminals to improve a user's way of working.I'm hoping to hand off this feature to anyone that's interested as I will not have the bandwidth to bring this feature up to parity with VSCode. This hopefully will serve as a good jumping off point for some interesting terminal view improvements to Theia. Happy to answer any questions otherwise :)
Description
How to test
alt+q
to maximize and minimize the terminal panel. This keybinding is meant to serve as a convenient way of switching between the normal "editor" view and a fullscreen "terminal" view. (you can also use the new toolbar item to maximize/minimize)Right click on tree nodes and try renaming nodes
Click on different nodes, corresponding terminals should flash when their node is selected (and vice versa)
Try deleting groups, pages, terminals from the tree widget (you won't be allowed to delete the last page/group/terminal for its respective parent, does this behavior make sense?)
Try showing and hiding the tree widget with this icon:
How to test
Review checklist
Reminder for reviewers